Messages in this thread | | | Subject | Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86 | From | "H. Peter Anvin" <> | Date | Tue, 14 Feb 2017 10:46:29 -0800 |
| |
On 02/14/17 09:56, Geert Uytterhoeven wrote: >> >> Well, almost. You need the wp_works_ok removal patch too, otherwise you >> have the 3 bytes hole below. > > That's because you removed a char in commit 93a829e8e2c292f1 > ("x86, cpu: Convert FDIV bug detection), without compensating with padding ;-) >
Padding isn't a problem (other than efficiency) for a structure which is strictly internal to the kernel as opposed to an ABI structure.
-hpa
| |