Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 14 Feb 2017 18:56:22 +0100 | Subject | Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86 |
| |
Hi Boris,
On Tue, Feb 14, 2017 at 5:17 PM, Borislav Petkov <bp@alien8.de> wrote: > On Sun, Feb 12, 2017 at 10:12:07PM +0100, Mathias Krause wrote: >> Those member serve no purpose -- not even fill padding for alignment or >> such. So just get rid of them. > > Well, almost. You need the wp_works_ok removal patch too, otherwise you > have the 3 bytes hole below.
That's because you removed a char in commit 93a829e8e2c292f1 ("x86, cpu: Convert FDIV bug detection), without compensating with padding ;-)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |