lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] tools lib traceevent: fix an incorrect comparison with the literal "s64"
Date
From: Colin Ian King <colin.king@canonical.com>

I believe the comparison of the string 'type' with the literal string
"s64" is currently incorrect, it is missing a == 0 comparison as per
the other comparisons.

Detected by cppcheck:
tools/lib/traceevent/event-parse.c:2209: (warning) The comparison
operator in 'strcmp(type,"s64") != 0' should maybe be '==' instead,
currently the expression 'strcmp(type,"u64") == 0' is redundant.

Fixes: f7d82350e597 ("tools/events: Add files to create libtraceevent.a")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
tools/lib/traceevent/event-parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 7ce724fc0544..82b6c64c5b39 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -2206,7 +2206,7 @@ eval_type_str(unsigned long long val, const char *type, int pointer)
return val & 0xffffffff;

if (strcmp(type, "u64") == 0 ||
- strcmp(type, "s64"))
+ strcmp(type, "s64") == 0)
return val;

if (strcmp(type, "s8") == 0)
--
2.14.1
\
 
 \ /
  Last update: 2017-11-27 17:20    [W:0.040 / U:2.780 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site