lkml.org 
[lkml]   [2017]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring
On Fri, Nov 24, 2017 at 03:52:05PM +0000, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > - construct_get_dest_keyring(&dest_keyring);
>
> This will break. construct_get_dest_keyring() does other things than just
> getting a ref on whatever dest_keyring points to.
>

Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in this
case.

Eric

\
 
 \ /
  Last update: 2017-11-24 21:38    [W:0.049 / U:1.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site