Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring | Date | Fri, 24 Nov 2017 21:24:30 +0000 |
| |
Eric Biggers <ebiggers3@gmail.com> wrote:
> if (dest_keyring) { > - construct_get_dest_keyring(&dest_keyring);
Actually, I think I have the order of these lines inverted. construct_get_dest_keyring() can actually return without setting dest_keyring to anything. This didn't used to be the case, but now that the user-session keyring is made lazily, there's no guaranteed fallback.
David
| |