lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3 v4] perf/x86/intel/uncore: Cache logical pkg id in uncore driver
On Wed, 25 Oct 2017, Prarit Bhargava wrote:

> From: Andi Kleen <ak@linux.intel.com>
>
> The SNB-EP uncore driver is the only user of topology_phys_to_logical_pkg
> in a performance critical path. Change it query the logical pkg ID
> only once at initialization time and then cache it in box structure.

That second sentence needs some care:

Avoid the lookup in the hotpath and cache the id at initialization
time. This is also a prerequisite to change the underlying logical
package management implementation w/o impacting this driver.

Other than that.

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

\
 
 \ /
  Last update: 2017-11-01 17:30    [W:0.085 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site