lkml.org 
[lkml]   [2017]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3 v4] perf/x86/intel/uncore: Cache logical pkg id in uncore driver
    Date
    From: Andi Kleen <ak@linux.intel.com>

    The SNB-EP uncore driver is the only user of topology_phys_to_logical_pkg
    in a performance critical path. Change it query the logical pkg ID
    only once at initialization time and then cache it in box structure.

    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: x86@kernel.org
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Dave Hansen <dave.hansen@intel.com>
    Cc: Piotr Luc <piotr.luc@intel.com>
    Cc: Kan Liang <kan.liang@intel.com>
    Cc: Borislav Petkov <bp@suse.de>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Prarit Bhargava <prarit@redhat.com>
    Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Christian Borntraeger <borntraeger@de.ibm.com>
    Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
    Cc: Tom Lendacky <thomas.lendacky@amd.com>
    Cc: Mathias Krause <minipli@googlemail.com>
    Cc: Tim Chen <tim.c.chen@linux.intel.com>
    Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
    ---
    arch/x86/events/intel/uncore.c | 1 +
    arch/x86/events/intel/uncore.h | 1 +
    arch/x86/events/intel/uncore_snbep.c | 2 +-
    3 files changed, 3 insertions(+), 1 deletion(-)

    diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c
    index d45e06346f14..87ef77982248 100644
    --- a/arch/x86/events/intel/uncore.c
    +++ b/arch/x86/events/intel/uncore.c
    @@ -947,6 +947,7 @@ static int uncore_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id

    atomic_inc(&box->refcnt);
    box->pci_phys_id = phys_id;
    + box->logical_pkg_id = topology_phys_to_logical_pkg(box->pci_phys_id);
    box->pkgid = pkg;
    box->pci_dev = pdev;
    box->pmu = pmu;
    diff --git a/arch/x86/events/intel/uncore.h b/arch/x86/events/intel/uncore.h
    index df5989f27b1b..6214cd33a9fb 100644
    --- a/arch/x86/events/intel/uncore.h
    +++ b/arch/x86/events/intel/uncore.h
    @@ -99,6 +99,7 @@ struct intel_uncore_extra_reg {

    struct intel_uncore_box {
    int pci_phys_id;
    + int logical_pkg_id;
    int pkgid;
    int n_active; /* number of active events */
    int n_events;
    diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
    index a7196818416a..252d371b488b 100644
    --- a/arch/x86/events/intel/uncore_snbep.c
    +++ b/arch/x86/events/intel/uncore_snbep.c
    @@ -1056,7 +1056,7 @@ static void snbep_qpi_enable_event(struct intel_uncore_box *box, struct perf_eve

    if (reg1->idx != EXTRA_REG_NONE) {
    int idx = box->pmu->pmu_idx + SNBEP_PCI_QPI_PORT0_FILTER;
    - int pkg = topology_phys_to_logical_pkg(box->pci_phys_id);
    + int pkg = box->logical_pkg_id;
    struct pci_dev *filter_pdev = uncore_extra_pci_dev[pkg].dev[idx];

    if (filter_pdev) {
    --
    2.15.0.rc0.39.g2f0e14e64
    \
     
     \ /
      Last update: 2017-10-25 14:10    [W:5.651 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site