lkml.org 
[lkml]   [2017]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFT PATCH v2] gpiolib: allow gpio irqchip to map irqs dynamically
From
Date


On 10/09/2017 02:57 PM, Linus Walleij wrote:
> On Mon, Oct 9, 2017 at 8:10 PM, Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
>
>> At the moment it was merged there were no user of irq_base except gpio-mockup.c.
>
> OK I feel calmer.
>
>> And actually there are shouldn't as calling irq_create_mapping() in cycle
>> will not guarantee sequential Linux IRQ numbers allocation.
>
> Yeah. I always felt that was bad practice.
>
> But we should really kill off that irq_base member from gpio_chip. It looks
> dangerous to have arond.

patch posted.

--
regards,
-grygorii

\
 
 \ /
  Last update: 2017-10-10 00:18    [W:0.139 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site