Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 9 Oct 2017 21:57:58 +0200 | Subject | Re: [RFT PATCH v2] gpiolib: allow gpio irqchip to map irqs dynamically |
| |
On Mon, Oct 9, 2017 at 8:10 PM, Grygorii Strashko <grygorii.strashko@ti.com> wrote:
> At the moment it was merged there were no user of irq_base except gpio-mockup.c.
OK I feel calmer.
> And actually there are shouldn't as calling irq_create_mapping() in cycle > will not guarantee sequential Linux IRQ numbers allocation.
Yeah. I always felt that was bad practice.
But we should really kill off that irq_base member from gpio_chip. It looks dangerous to have arond.
Yours, Linus Walleij
| |