| Date | Sat, 21 Oct 2017 10:42:53 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 10/14] soundwire: Add sysfs for SoundWire DisCo properties |
| |
On Thu, Oct 19, 2017 at 08:33:26AM +0530, Vinod Koul wrote:
> +static ssize_t clock_frequencies_show(struct sdw_bus *bus, > + struct sdw_prop_attribute *attr, char *buf) > +{ > + ssize_t size = 0; > + int i; > + > + for (i = 0; i < bus->prop.num_freq; i++) > + size += sprintf(buf + size, "%8d\n", bus->prop.freq[i]); > + > + return size; > +}
sysfs is supposed to be one value per file...
> +int sdw_sysfs_slave_init(struct sdw_slave *slave) > +{ > + /* TODO: Initialize dp0 and dpn kobject and attribute */ > + return 0; > +} > + > +void sdw_sysfs_slave_exit(struct sdw_slave *slave) > +{ > +}
Seems like an important TODO? [unhandled content-type:application/pgp-signature] |