lkml.org 
[lkml]   [2017]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/14] soundwire: Add SoundWire bus type
On Sat, Oct 21, 2017 at 10:03:48AM +0100, Mark Brown wrote:
> On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote:
>
> > + ret = dev_pm_domain_attach(dev, false);
> > + if (ret) {
> > + dev_err(dev, "Failed to attach PM domain: %d\n", ret);
> > + return ret;
> > + }
> > +
> > + ret = drv->probe(slave, id);
> > + if (ret) {
> > + dev_err(dev, "Probe of %s failed: %d\n", drv->name, ret);
> > + return ret;
> > + }
>
> We don't detach the power domain if the probe fails.

we should, thanks for spotting

--
~Vinod

\
 
 \ /
  Last update: 2017-10-22 17:50    [W:0.333 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site