Messages in this thread | | | Date | Wed, 18 Oct 2017 18:04:36 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations |
| |
On Mon, Oct 16, 2017 at 10:44:18PM +0200, SF Markus Elfring wrote: > > A minor complaint: all commits are missing "Fixes:" tag. > > * Do you require it to be added to the commit messages?
I don't require it. It's part of the development process:
https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html
> * Would you like to get a finer patch granularity then?
I don't understand what you are asking.
> * Do you find any more information missing? > > Regards, > Markus
I think I already answered to this in my earlier responses (commit messages).
I probably won't take "sizeof(*foo)" type of change even if it is a recommended style if that is the only useful thing that the commit does.
/Jarkko
| |