lkml.org 
[lkml]   [2017]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Staging: braille_console: fixed 3 warn, 1 err (using checkpatch)
Fixed some coding style issues.

- ERROR: Use 4 digit octal (0777) not decimal permissions (48)
- WARNING: Missing a blank line after declarations (241, 280, 288)

Signed-off-by: Olaf Luijks <oluijks@gmail.com>
---
drivers/accessibility/braille/braille_console.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c
index dc34a5b..340fda0 100644
--- a/drivers/accessibility/braille/braille_console.c
+++ b/drivers/accessibility/braille/braille_console.c
@@ -45,7 +45,7 @@ MODULE_LICENSE("GPL");

/* Emit various sounds */
static bool sound;
-module_param(sound, bool, 0);
+module_param(sound, bool, 0000);
MODULE_PARM_DESC(sound, "emit sounds");

static void beep(unsigned int freq)
@@ -238,6 +238,7 @@ static int keyboard_notifier_call(struct notifier_block *blk,
case KBD_POST_KEYSYM:
{
unsigned char type = KTYP(param->value) - 0xf0;
+
if (type == KT_SPEC) {
unsigned char val = KVAL(param->value);
int on_off = -1;
@@ -277,6 +278,7 @@ static int vt_notifier_call(struct notifier_block *blk,
{
struct vt_notifier_param *param = _param;
struct vc_data *vc = param->vc;
+
switch (code) {
case VT_ALLOCATE:
break;
@@ -285,6 +287,7 @@ static int vt_notifier_call(struct notifier_block *blk,
case VT_WRITE:
{
unsigned char c = param->c;
+
if (vc->vc_num != fg_console)
break;
switch (c) {
--
2.9.0
\
 
 \ /
  Last update: 2017-01-05 01:08    [W:0.050 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site