Messages in this thread | | | Date | Mon, 23 Jan 2017 10:16:10 +0100 | From | Johannes Thumshirn <> | Subject | Re: [PATCH 2/5] blk-throttle: Move an assignment for the variable "ret" in tg_set_conf() |
| |
On Sun, Jan 22, 2017 at 09:32:19AM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 21 Jan 2017 21:40:38 +0100 > > A local variable was set to an error code before a concrete error situation > was detected. Thus move the corresponding assignment into an if branch > to indicate a software failure there. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > ---
See my answer to the last patch.
-- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
| |