lkml.org 
[lkml]   [2017]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/5] blk-throttle: Move three assignments for the variable "ret" in tg_set_max()
From
Date
>> @@ -1327,27 +1327,30 @@ static ssize_t tg_set_max(struct kernfs_open_file *of,
>> break;
>> ctx.body += len;
>>
>> - ret = -EINVAL;
>> p = tok;
>> strsep(&p, "=");
>> - if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max")))
>> + if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max"))) {
>> + ret = -EINVAL;
>> goto out_finish;
>> + }
>
> Sorry, I don't like this patch. We know the next error if we encounter one
> will be EINVAL until we change it.

Thanks for your constructive feedback.


> Your patch doesn't introduce a functual change and doesn't improve readability,
> so I don't really see a point for it.

We have got different preferences for the placement of error code settings.
Do you care about run time changes there?

Regards,
Markus

\
 
 \ /
  Last update: 2017-01-23 11:01    [W:0.038 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site