Messages in this thread | | | Date | Mon, 16 Jan 2017 12:09:30 +0200 | From | Leon Romanovsky <> | Subject | Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check |
| |
On Mon, Jan 16, 2017 at 10:55:22AM +0100, Borislav Petkov wrote: > On Mon, Jan 16, 2017 at 11:48:51AM +0200, Leon Romanovsky wrote: > > Almost, except one point - pr_warn and dump_stack have different log > > Actually, Michal pointed out on IRC a more relevant difference: > > WARN() taints the kernel and we don't want that for GFP flags misuse.
And doesn't dump_stack do the same? It pollutes the log too.
> Also, from looking at __warn(), it checks panic_on_warn and we explode > if set.
Right, it is very valid point.
> > So no, we probably don't want WARN() here.
I understand, Thanks.
> > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply. [unhandled content-type:application/pgp-signature] | |