Messages in this thread | | | Date | Mon, 16 Jan 2017 10:55:22 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check |
| |
On Mon, Jan 16, 2017 at 11:48:51AM +0200, Leon Romanovsky wrote: > Almost, except one point - pr_warn and dump_stack have different log
Actually, Michal pointed out on IRC a more relevant difference:
WARN() taints the kernel and we don't want that for GFP flags misuse. Also, from looking at __warn(), it checks panic_on_warn and we explode if set.
So no, we probably don't want WARN() here.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |