Messages in this thread | | | Subject | Re: [PATCH 8/8] mmc-core: Use kmalloc_array() in mmc_alloc_sg() | From | Shawn Lin <> | Date | Tue, 10 Jan 2017 16:27:19 +0800 |
| |
On 2017/1/9 5:55, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 8 Jan 2017 22:10:40 +0100 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. >
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/mmc/core/queue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c > index a6496d8027bc..b1986622c60e 100644 > --- a/drivers/mmc/core/queue.c > +++ b/drivers/mmc/core/queue.c > @@ -152,7 +152,7 @@ static struct scatterlist *mmc_alloc_sg(int sg_len, int *err) > { > struct scatterlist *sg; > > - sg = kmalloc(sizeof(struct scatterlist)*sg_len, GFP_KERNEL); > + sg = kmalloc_array(sg_len, sizeof(*sg), GFP_KERNEL); > if (!sg) > *err = -ENOMEM; > else { >
-- Best Regards Shawn Lin
| |