lkml.org 
[lkml]   [2017]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 6/8] mmc/core/mmc_test: Improve a size determination in five functions
From
Date
On 2017/1/9 5:49, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 8 Jan 2017 21:25:44 +0100
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>


Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/mmc/core/mmc_test.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index bb9f569a5dd5..294d3c675734 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -356,7 +356,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz,
> if (max_segs > max_page_cnt)
> max_segs = max_page_cnt;
>
> - mem = kzalloc(sizeof(struct mmc_test_mem), GFP_KERNEL);
> + mem = kzalloc(sizeof(*mem), GFP_KERNEL);
> if (!mem)
> return NULL;
>
> @@ -545,7 +545,7 @@ static void mmc_test_save_transfer_result(struct mmc_test_card *test,
> if (!test->gr)
> return;
>
> - tr = kmalloc(sizeof(struct mmc_test_transfer_result), GFP_KERNEL);
> + tr = kmalloc(sizeof(*tr), GFP_KERNEL);
> if (!tr)
> return;
>
> @@ -2973,8 +2973,7 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase)
> }
> }
>
> - gr = kzalloc(sizeof(struct mmc_test_general_result),
> - GFP_KERNEL);
> + gr = kzalloc(sizeof(*gr), GFP_KERNEL);
> if (gr) {
> INIT_LIST_HEAD(&gr->tr_lst);
>
> @@ -3108,7 +3107,7 @@ static ssize_t mtf_test_write(struct file *file, const char __user *buf,
> if (ret)
> return ret;
>
> - test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL);
> + test = kzalloc(sizeof(*test), GFP_KERNEL);
> if (!test)
> return -ENOMEM;
>
> @@ -3213,7 +3212,7 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
> return -ENODEV;
> }
>
> - df = kmalloc(sizeof(struct mmc_test_dbgfs_file), GFP_KERNEL);
> + df = kmalloc(sizeof(*df), GFP_KERNEL);
> if (!df) {
> debugfs_remove(file);
> dev_err(&card->dev,
>


--
Best Regards
Shawn Lin

\
 
 \ /
  Last update: 2017-01-10 09:32    [W:0.195 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site