Messages in this thread | | | Date | Fri, 16 Sep 2016 07:51:23 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3] leds: Introduce userspace leds driver |
| |
On Thu 2016-09-15 10:31:50, David Lechner wrote: > On 09/15/2016 09:54 AM, Jacek Anaszewski wrote: > >Hi Pavel, > > > >On 09/15/2016 03:08 PM, Pavel Machek wrote: > >>Hi! > >> > >>>>+ if (copy_from_user(&udev->user_dev, buffer, > >>>>+ sizeof(struct uleds_user_dev))) { > >>>>+ ret = -EFAULT; > >>>>+ goto out; > >>>>+ } > >>>>+ > >>>>+ if (!udev->user_dev.name[0]) { > >>>>+ ret = -EINVAL; > >>>>+ goto out; > >>>>+ } > >>>>+ > >>>>+ ret = led_classdev_register(NULL, &udev->led_cdev); > >>>>+ if (ret < 0) > >>>>+ goto out; > >> > >>No sanity checking on the name -> probably a security hole. Do not > >>push this upstream before this is fixed. > > > >Thanks for catching this. > > > >David, please check if the LED name sticks to the LED class > >device naming convention. > > I don't think it is a good idea to enforce the LED class naming convention. > Someone may have a userspace application they want to test that has a > hard-coded name that does not follow the convention.
Umm.
Noone has applications with hardcoded names that are not possible today, right?
And better not encourage crazy names.
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |