Messages in this thread | | | Date | Fri, 16 Sep 2016 08:07:18 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3] leds: Introduce userspace leds driver |
| |
Hi!
+static ssize_t uleds_read(struct file *file, char __user *buffer, size_t count, + loff_t *ppos) +{ + struct uleds_device *udev = file->private_data; + ssize_t retval; + + if (count == 0) + return 0; + + if (count != 1) + return -EINVAL;
This is quite anti-social. You are free to return 1 byte on any read (short read), but please allow reads with bigger buffers.
Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |