Messages in this thread | | | From | David Binderman <> | Date | Mon, 8 Aug 2016 14:46:53 +0100 | Subject | linux-4.8-rc1/drivers/scsi/sd.c:317: pointless test ? |
| |
Hello there,
linux-4.8-rc1/drivers/scsi/sd.c:317]: (style) Unsigned variable 'val' can't be negative so it is unnecessary to test it.
Source code is
if (val >= 0 && val <= SD_DIF_TYPE3_PROTECTION)
but
unsigned int val;
Suggest new code
if (val <= SD_DIF_TYPE3_PROTECTION)
Regards
David Binderman
| |