lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 0579/1285] Replace numeric parameter like 0444 with macro
Date
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/media/usb/cx231xx/cx231xx-cards.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c
index c63248a..79e2a8b 100644
--- a/drivers/media/usb/cx231xx/cx231xx-cards.c
+++ b/drivers/media/usb/cx231xx/cx231xx-cards.c
@@ -37,15 +37,15 @@


static int tuner = -1;
-module_param(tuner, int, 0444);
+module_param(tuner, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(tuner, "tuner type");

static int transfer_mode = 1;
-module_param(transfer_mode, int, 0444);
+module_param(transfer_mode, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(transfer_mode, "transfer mode (1-ISO or 0-BULK)");

static unsigned int disable_ir;
-module_param(disable_ir, int, 0444);
+module_param(disable_ir, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(disable_ir, "disable infrared remote support");

/* Bitmask marking allocated devices from 0 to CX231XX_MAXBOARDS */
--
2.9.2
\
 
 \ /
  Last update: 2016-08-02 14:41    [W:0.187 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site