lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 0310/1285] Replace numeric parameter like 0444 with macro
Date
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/lightnvm/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index 160c1a6..8dec614 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -1032,7 +1032,7 @@ static const struct kernel_param_ops nvm_configure_by_str_event_param_ops = {
#define MODULE_PARAM_PREFIX "lnvm."

module_param_cb(configure_debug, &nvm_configure_by_str_event_param_ops, NULL,
- 0644);
+ S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

#endif /* CONFIG_NVM_DEBUG */

--
2.9.2
\
 
 \ /
  Last update: 2016-08-02 20:41    [W:0.217 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site