Messages in this thread Patch in this message | | | From | Baole Ni <> | Subject | [PATCH 0539/1285] Replace numeric parameter like 0444 with macro | Date | Tue, 2 Aug 2016 19:22:11 +0800 |
| |
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> Signed-off-by: Baole Ni <baolex.ni@intel.com> --- drivers/media/radio/radio-rtrack2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/radio/radio-rtrack2.c b/drivers/media/radio/radio-rtrack2.c index 09cfbc3..9609072 100644 --- a/drivers/media/radio/radio-rtrack2.c +++ b/drivers/media/radio/radio-rtrack2.c @@ -39,9 +39,9 @@ static int io[RTRACK2_MAX] = { [0] = CONFIG_RADIO_RTRACK2_PORT, [1 ... (RTRACK2_MAX - 1)] = -1 }; static int radio_nr[RTRACK2_MAX] = { [0 ... (RTRACK2_MAX - 1)] = -1 }; -module_param_array(io, int, NULL, 0444); +module_param_array(io, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(io, "I/O addresses of the RadioTrack card (0x20f or 0x30f)"); -module_param_array(radio_nr, int, NULL, 0444); +module_param_array(radio_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(radio_nr, "Radio device numbers"); static struct radio_isa_card *rtrack2_alloc(void) -- 2.9.2
| |