Messages in this thread | | | Subject | Re: [PATCH 0829/1285] Replace numeric parameter like 0444 with macro | From | Larry Finger <> | Date | Tue, 2 Aug 2016 09:50:23 -0500 |
| |
On 08/02/2016 06:50 AM, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> > Signed-off-by: Baole Ni <baolex.ni@intel.com>
I'm not sure how much these changes improve robustness and/or readability, but they cause no harm. For that reason, the changes in rtlwifi drivers is acked.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
> --- > drivers/pcmcia/cistpl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c > index 55ef7d1..ac6f619 100644 > --- a/drivers/pcmcia/cistpl.c > +++ b/drivers/pcmcia/cistpl.c > @@ -57,7 +57,7 @@ static const u_int exponent[] = { > > /* 16-bit CIS? */ > static int cis_width; > -module_param(cis_width, int, 0444); > +module_param(cis_width, int, S_IRUSR | S_IRGRP | S_IROTH); > > void release_cis_mem(struct pcmcia_socket *s) > { >
| |