lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0829/1285] Replace numeric parameter like 0444 with macro
From
Date
On 02/08/16 13:50, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>

This is the worst series of lkml spam I've ever received!

1. Make something like this a series in one thread, not 1285 single
threads! Add a cover letter.
2. Don't write one patch per source file, one per subsystem is enough.
Maybe even better: make a tree-wide patch using Coccinelle.
3. Use better subjects. I want to see the subsystem the patch is
modifying.
4. Use _correct_ maintainers. WTF do I have to do with pcmcia?


Juergen

\
 
 \ /
  Last update: 2016-08-02 17:41    [W:2.107 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site