Messages in this thread Patch in this message | | | From | Baole Ni <> | Subject | [PATCH 0977/1285] Replace numeric parameter like 0444 with macro | Date | Tue, 2 Aug 2016 20:04:35 +0800 |
| |
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> Signed-off-by: Baole Ni <baolex.ni@intel.com> --- drivers/usb/gadget/legacy/g_ffs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/legacy/g_ffs.c b/drivers/usb/gadget/legacy/g_ffs.c index f85639e..79f931c 100644 --- a/drivers/usb/gadget/legacy/g_ffs.c +++ b/drivers/usb/gadget/legacy/g_ffs.c @@ -79,11 +79,11 @@ static struct usb_device_descriptor gfs_dev_desc = { static char *func_names[GFS_MAX_DEVS]; static unsigned int func_num; -module_param_named(bDeviceClass, gfs_dev_desc.bDeviceClass, byte, 0644); +module_param_named(bDeviceClass, gfs_dev_desc.bDeviceClass, byte, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(bDeviceClass, "USB Device class"); -module_param_named(bDeviceSubClass, gfs_dev_desc.bDeviceSubClass, byte, 0644); +module_param_named(bDeviceSubClass, gfs_dev_desc.bDeviceSubClass, byte, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(bDeviceSubClass, "USB Device subclass"); -module_param_named(bDeviceProtocol, gfs_dev_desc.bDeviceProtocol, byte, 0644); +module_param_named(bDeviceProtocol, gfs_dev_desc.bDeviceProtocol, byte, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(bDeviceProtocol, "USB Device protocol"); module_param_array_named(functions, func_names, charp, &func_num, 0); MODULE_PARM_DESC(functions, "USB Functions list"); -- 2.9.2
| |