Messages in this thread Patch in this message | | | From | Arvind Yadav <> | Subject | [PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error, since the cleanup function has been already called by the | Date | Tue, 5 Jul 2016 21:48:20 +0530 |
| |
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/input/keyboard/gpio_keys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 2909365..a2fa3bb 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c @@ -542,7 +542,8 @@ static int gpio_keys_setup_key(struct platform_device *pdev, * Install custom action to cancel release timer and * workqueue item. */ - error = devm_add_action(&pdev->dev, gpio_keys_quiesce_key, bdata); + error = devm_add_action_or_reset(&pdev->dev, gpio_keys_quiesce_key, + bdata); if (error) { dev_err(&pdev->dev, "failed to register quiesce action, error: %d\n", -- 1.9.1
| |