Messages in this thread | | | From | David Binderman <> | Date | Mon, 13 Jun 2016 09:16:24 +0100 | Subject | linux-4.7-rc3/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4836: wierd condition ? |
| |
Hello there,
linux-4.7-rc3/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4836]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.
Source code is
if ((ring->me == me_id) & (ring->pipe == pipe_id))
Maybe better code
if ((ring->me == me_id) && (ring->pipe == pipe_id))
Also in the same file:
[drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3866]: (style) Variable 'data' is assigned a value that is never used. [drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4321]: (style) Variable 'mc_shared_chmap' is assigned a value that is never used. [drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4657]: (style) Variable 'tmp' is assigned a value that is never used.
Regards
David Binderman
| |