Messages in this thread | | | From | Julian Calaby <> | Date | Wed, 1 Jun 2016 14:23:11 +1000 | Subject | Re: [PATCH 8/8] mwifiex: use better message and error code when OF node doesn't match |
| |
Hi All,
On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > The Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT > binding document lists the possible compatible strings that a SDIO child > node can have, so the driver checks if the defined in the node matches. > > But the error message when that's not the case is misleading, so change > for one that makes clear what the error really is. Also, returning a -1 > as errno code is not correct since that's -EPERM. A -EINVAL seems to be > a more appropriate one. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks,
-- Julian Calaby
Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
| |