lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver
From
Date
fu.wei@linaro.org wrote:
> +static struct platform_driver sbsa_gwdt_driver = {
> + .driver = {
> + .name = "sbsa-gwdt",
> + .pm = &sbsa_gwdt_pm_ops,
> + .of_match_table = sbsa_gwdt_of_match,
> + },
> + .probe = sbsa_gwdt_probe,
> + .remove = sbsa_gwdt_remove,
> + .shutdown = sbsa_gwdt_shutdown,
> + .id_table = sbsa_gwdt_pdev_match,
> +};

I just noticed you dropped ACPI support. Server platforms are supposed
to use ACPI, so that seems like a critical omission to me. You had a
GTDT parser in an older version of this patch. What happened to it?

\
 
 \ /
  Last update: 2016-02-03 19:01    [W:0.143 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site