Messages in this thread | | | Subject | Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support | From | Timur Tabi <> | Date | Wed, 3 Feb 2016 11:27:31 -0600 |
| |
fu.wei@linaro.org wrote: > +#ifdef CONFIG_ARM_SBSA_WATCHDOG_PANIC > +static bool panic_enabled = true;
I think this should default to 'false', because IMHO, this seems like an odd feature. I'm not crazy about the fact that there's a Kconfig option for it either, but I'm not going to NACK this patch.
I personally would prefer to drop this patch, and just wait for full-blown pre-timeout support. It feels like a debugging feature that doesn't really belong upstream. But like I said, it's just my opinion, and I won't complain if I'm outvoted.
| |