Messages in this thread | | | From | Mika Penttilä <> | Subject | [REGRESSION, bisected] 4.5rc4 sound fsl-soc | Date | Mon, 15 Feb 2016 13:25:19 +0200 |
| |
Hi,
The following commit :
5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit commit 5c408fee254633a5be69505bc86c6b034f871ab4 Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Date: Mon Jan 18 20:07:44 2016 +0100
ASoC: fsl_ssi: remove explicit register defaults
There is no guarantee that on fsl_ssi module load SSI registers will have their power-on-reset values.
In fact, if the driver is reloaded the values in registers will be whatever they were set to previously.
However, the cache needs to be fully populated at probe time to avoid non-atomic allocations during register access.
Special case here is imx21-class SSI, since according to datasheet it don't have SACC{ST,EN,DIS} regs. This fixes hard lockup on fsl_ssi module reload, at least in AC'97 mode. Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast") Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Tested-by: Fabio Estevam <fabio.estevam@nxp.com> Signed-off-by: Mark Brown <broonie@kernel.org>
causes regmap init failure when loading the sgtl5000 codec on imx6q, and leads to no audio.
With the mentioned patch reverted sound works ok.
--Mika
| |