Messages in this thread Patch in this message | | | From | Peter Foley <> | Subject | [PATCH] Annotate die() with noreturn | Date | Sat, 26 Nov 2016 17:22:29 -0500 |
| |
Fixes below warning with clang:
In file included from ../arch/x86/tools/relocs_64.c:17: ../arch/x86/tools/relocs.c:977:6: warning: variable 'do_reloc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (!use_real_mode) ^~~~~~~~~~~~~~ ../arch/x86/tools/relocs.c:989:14: note: uninitialized use occurs here walk_relocs(do_reloc); ^~~~~~~~ ../arch/x86/tools/relocs.c:977:2: note: remove the 'if' if its condition is always true if (!use_real_mode) ^~~~~~~~~~~~~~~~~~~ ../arch/x86/tools/relocs.c:974:24: note: initialize the variable 'do_reloc' to silence this warning const char *symname); ^ = NULL
Signed-off-by: Peter Foley <pefoley2@pefoley.com> --- arch/x86/tools/relocs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/tools/relocs.h b/arch/x86/tools/relocs.h index f59590645b68..1d23bf953a4a 100644 --- a/arch/x86/tools/relocs.h +++ b/arch/x86/tools/relocs.h @@ -16,7 +16,7 @@ #include <regex.h> #include <tools/le_byteshift.h> -void die(char *fmt, ...); +void die(char *fmt, ...) __attribute__((noreturn)); #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) -- 2.11.0.rc2
| |