Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] staging: lustre: lov: Fix signed wrap around when decrementing index 'i' | Date | Thu, 10 Nov 2016 14:19:10 +0000 |
| |
From: Colin Ian King <colin.king@canonical.com>
Change predecrement compare to post decrement compare to avoid an unsigned integer wrap-around comparisomn when decrementing in the while loop.
Issue found with static analysis with CoverityScan, CID 1375917
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/staging/lustre/lustre/lov/lov_ea.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c index 53db170..399298c 100644 --- a/drivers/staging/lustre/lustre/lov/lov_ea.c +++ b/drivers/staging/lustre/lustre/lov/lov_ea.c @@ -102,7 +102,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count) return lsm; err: - while (--i >= 0) + while (i-- > 0) kmem_cache_free(lov_oinfo_slab, lsm->lsm_oinfo[i]); kvfree(lsm); return NULL; -- 2.10.2
| |