Messages in this thread | | | From | Binoy Jayan <> | Date | Tue, 25 Oct 2016 18:16:17 +0530 | Subject | Re: [PATCH v2 8/8] IB/mlx5: Add helper mlx5_ib_post_send_wait |
| |
On 25 October 2016 at 17:53, Arnd Bergmann <arnd@arndb.de> wrote: > On Tuesday, October 25, 2016 5:31:59 PM CEST Binoy Jayan wrote: > Looks reasonable.
Thank you Arnd for looking at it again.
> Did you get a warning about 'bad' being unused here? I would have > guessed not, since the original code was not that different and > it does get passed into a function.
I remembered getting a warning like that, but when i remove the unused attribute now, it does not. It was probably a side effect of some other error. Will change it.
> Why not move the umr_context variable into this function too? > The only thing we ever seem to do to is initialize it and > assign the wr_cqe pointer, both of which can be done here.
I guess it could be done.
Binoy
| |