Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v2 8/8] IB/mlx5: Add helper mlx5_ib_post_send_wait | Date | Tue, 25 Oct 2016 14:23:43 +0200 |
| |
On Tuesday, October 25, 2016 5:31:59 PM CEST Binoy Jayan wrote: > Clean up common code (to post a list of work requests to the send queue of > the specified QP) at various places and add a helper function > 'mlx5_ib_post_send_wait' to implement the same. The counting semaphore > 'umr_common:sem' is also moved into the helper. This may later be modified > to replace the semaphore with an alternative. > > Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
Looks reasonable.
> --- > drivers/infiniband/hw/mlx5/mr.c | 96 +++++++++++++---------------------------- > 1 file changed, 29 insertions(+), 67 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > index d4ad672..261984b 100644 > --- a/drivers/infiniband/hw/mlx5/mr.c > +++ b/drivers/infiniband/hw/mlx5/mr.c > @@ -856,16 +856,38 @@ static inline void mlx5_ib_init_umr_context(struct mlx5_ib_umr_context *context) > init_completion(&context->done); > } > > +static inline int mlx5_ib_post_send_wait(struct mlx5_ib_dev *dev, > + struct mlx5_ib_umr_context *umr_context, > + struct mlx5_umr_wr *umrwr) > +{ > + struct umr_common *umrc = &dev->umrc; > + struct ib_send_wr __maybe_unused *bad;
Did you get a warning about 'bad' being unused here? I would have guessed not, since the original code was not that different and it does get passed into a function.
Why not move the umr_context variable into this function too? The only thing we ever seem to do to is initialize it and assign the wr_cqe pointer, both of which can be done here.
Arnd
| |