[lkml]   [2016]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86: Add an explicit barrier() to clflushopt()
On Sat, Jan 9, 2016 at 12:01 AM, Chris Wilson <> wrote:
> On Thu, Jan 07, 2016 at 02:32:23PM -0800, H. Peter Anvin wrote:
>> On 01/07/16 14:29, H. Peter Anvin wrote:
>> >
>> > I would be very interested in knowing if replacing the final clflushopt
>> > with a clflush would resolve your problems (in which case the last mb()
>> > shouldn't be necessary either.)
>> >
>> Nevermind. CLFLUSH is not ordered with regards to CLFLUSHOPT to the
>> same cache line.
>> Could you add a sync_cpu(); call to the end (can replace the final mb())
>> and see if that helps your case?
> s/sync_cpu()/sync_core()/
> No. I still see failures on Baytrail and Braswell (Pineview is not
> affected) with the final mb() replaced with sync_core(). I can reproduce
> failures on Pineview by tweaking the clflush_cache_range() parameters,
> so I am fairly confident that it is validating the current code.
> iirc sync_core() is cpuid, a heavy serialising instruction, an
> alternative to mfence. Is there anything that else I can infer about
> the nature of my bug from this result?

No clue, but I don't know much about the underlying architecture.

Can you try clflush_cache_ranging one cacheline less and then manually
doing clflushopt; mb on the last cache line, just to make sure that
the helper is really doing the right thing? You could also try
clflush instead of clflushopt to see if that makes a difference.


Andy Lutomirski
AMA Capital Management, LLC

 \ /
  Last update: 2016-01-10 00:21    [W:0.144 / U:10.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site