lkml.org 
[lkml]   [2016]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 16/16] mm/slab: introduce new slab management type, OBJFREELIST_SLAB
From
Date
On 01/14/2016 06:24 AM, Joonsoo Kim wrote:
> In fact, I tested another idea implementing OBJFREELIST_SLAB with
> extendable linked array through another freed object. It can remove
> memory waste completely but it causes more computational overhead
> in critical lock path and it seems that overhead outweigh benefit.
> So, this patch doesn't include it.

Can you elaborate? Do we actually need an extendable linked array? Why not just
store the pointer to the next free object into the object, NULL for the last
one? I.e. a singly-linked list. We should never need to actually traverse it?

freeing object obj:
*obj = page->freelist;
page->freelist = obj;

allocating object:
obj = page->freelist;
page->freelist = *obj;
*obj = NULL;

That means two writes, but if we omit managing page->active, it's not an
increase. For counting free objects, we would need to traverse the list, but
that's only needed for debugging?

Also during bulk operations, page->freelist could be updated just once at the
very end.

Vlastimil

\
 
 \ /
  Last update: 2016-01-27 15:21    [W:0.106 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site