lkml.org 
[lkml]   [2015]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()

Seems OK to me.

Thanks.

On 09/30/2015 05:33 PM, Xishi Qiu wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow,
> this patch fix the problem.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
> mm/page_alloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 48aaf7b..af3c9bd 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5668,6 +5668,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)
> */
> required_movablecore =
> roundup(required_movablecore, MAX_ORDER_NR_PAGES);
> + required_movablecore = min(totalpages, required_movablecore);
> corepages = totalpages - required_movablecore;
>
> required_kernelcore = max(required_kernelcore, corepages);



\
 
 \ /
  Last update: 2015-09-30 13:01    [W:0.531 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site