Messages in this thread | | | Date | Thu, 01 Oct 2015 13:02:40 -0700 (PDT) | From | Yasuaki Ishimatsu <> | Subject | Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes() |
| |
On Wed, 30 Sep 2015 17:33:42 +0800 Xishi Qiu <qiuxishi@huawei.com> wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow, > this patch fix the problem. > > Signed-off-by: Xishi Qiu <qiuxishi@huawei.com> > ---
Looks good to me.
Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thanks, Yasuaki Ishimatsu
> mm/page_alloc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 48aaf7b..af3c9bd 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5668,6 +5668,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > */ > required_movablecore = > roundup(required_movablecore, MAX_ORDER_NR_PAGES); > + required_movablecore = min(totalpages, required_movablecore); > corepages = totalpages - required_movablecore; > > required_kernelcore = max(required_kernelcore, corepages); > -- > 2.0.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |