lkml.org 
[lkml]   [2015]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mtd: mtdram: fix build error
Date
i386 allmodconfig fails with:
ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined!
ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined!

arm allmodconfig fails with:
ERROR: "__aeabi_uldivmod" [drivers/mtd/devices/mtdram.ko] undefined!
ERROR: "__aeabi_ldivmod" [drivers/mtd/devices/mtdram.ko] undefined!

The modulus operation is not being supported by these compilers. Use
do_div() instead which returns the remainder.

Fixes: 7827e3acad2d ("mtd: mtdram: check offs and len in mtdram->erase")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/mtd/devices/mtdram.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/devices/mtdram.c b/drivers/mtd/devices/mtdram.c
index 73fa297..d085167 100644
--- a/drivers/mtd/devices/mtdram.c
+++ b/drivers/mtd/devices/mtdram.c
@@ -35,15 +35,21 @@ static struct mtd_info *mtd_info;
static int check_offs_len(struct mtd_info *mtd, loff_t ofs, uint64_t len)
{
int ret = 0;
+ unsigned long temp_len, rem;

/* Start address must align on block boundary */
- if (ofs % mtd->erasesize) {
+ temp_len = ofs;
+ rem = do_div(temp_len, mtd->erasesize);
+ if (rem) {
pr_debug("%s: unaligned address\n", __func__);
ret = -EINVAL;
}

/* Length must align on block boundary */
- if (len % mtd->erasesize) {
+ temp_len = len;
+ rem = do_div(temp_len, mtd->erasesize);
+
+ if (rem) {
pr_debug("%s: length not block aligned\n", __func__);
ret = -EINVAL;
}
--
1.9.1


\
 
 \ /
  Last update: 2015-09-30 11:01    [W:0.048 / U:25.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site