| Date | Tue, 18 Aug 2015 23:32:09 -0700 | Subject | Re: [PATCH v3 27/51] PCI: Move ISA ioport align out of calculate_iosize | From | Yinghai Lu <> |
| |
On Mon, Aug 17, 2015 at 9:11 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: > On Mon, Jul 27, 2015 at 04:29:45PM -0700, Yinghai Lu wrote: >> So we could unify calculate_iosize and calculate_memsize later. > > Please make this a complete sentence, not just a continuation of the > summary line. > >> when one bridge have several children devices, and every devices >> have several io port resources and resource size < 0x400. > > This isn't a sentence either, so I'm not sure what this is supposed to > mean.
will change to:
Subject: [PATCH] PCI: Move ISA io port align out of calculate_iosize()
We can move ISA io port align out of calculate_iosize(), so we could unify calculate_iosize and calculate_memsize later.
That extra aligning or offset is to work around ISA devices: When one bridge have several children devices, and every device has several io port resources and resource size < 0x400. We need to check size, and add extra size to make sure bit8/9 to be zero.
|