lkml.org 
[lkml]   [2015]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 28/51] PCI: Unifiy calculate_size for io port and mmio
    From
    On Mon, Aug 17, 2015 at 9:13 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
    > On Mon, Jul 27, 2015 at 04:29:46PM -0700, Yinghai Lu wrote:
    >> We should check size+size1 with min_size for io port.
    >> For example, when hotplug bridge has two children bridges,
    >> every child bridge will need 0x1000, so size1 will be 0x2000
    >> and size is 0. The min_size for the hotplug bridge is 0x100.
    >
    > A min_size of 0x100? Is that a typo?

    yes, it is 0x100.

    #define DEFAULT_HOTPLUG_IO_SIZE (256)
    /* pci=hpmemsize=nnM,hpiosize=nn can override this */
    unsigned long pci_hotplug_io_size = DEFAULT_HOTPLUG_IO_SIZE;

    and we have

    if (bus->self->is_hotplug_bridge) {
    min_io_size = pci_hotplug_io_size;

    >
    >> with old version calculate_iosize, we get 0x3000 for final
    >> size because we are using size to compare with min_size. That is
    >> not right, we should use 0x2000 instead.
    >
    > If this fixes a bug, please make one patch that *only* fixes the bug,
    > and a separate one that unifies but doesn't change the behavior.

    ok, will separate it into two.


    \
     
     \ /
      Last update: 2015-08-19 08:41    [W:6.295 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site