lkml.org 
[lkml]   [2015]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [dm-devel] WARNING: at fs/block_dev.c:5 when removing LV on removed device
> In that case if I do umount after device has gone away, I can see above
> WARN(). And it does seem to be coming from.
>
> WARN_ON_ONCE(write_inode_now(inode, true))
>
> If we failed to write back inode, then warning about it sounds right?

WARN() is for detecting kernel internal consistency problems, like
potential bugs. It's not for handling IO errors or really
everything that can happen on a non buggy kernel.


> What's wrong with that? Should it be just a kernel log of level KERN_WARN
> instead?

Yes. Something like that.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2015-06-18 22:21    [W:0.077 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site