lkml.org 
[lkml]   [2015]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: WARNING: at fs/block_dev.c:5 when removing LV on removed device
On Thu, Jun 18, 2015 at 03:28:21PM -0400, Mike Snitzer wrote:
> > WARN_ON_ONCE(write_inode_now(inode, true))
> >
> > If we failed to write back inode, then warning about it sounds right?
>
> A warning is fine.. not a WARN_ON(). Pretty alarming backtrace spew but
> maybe I'm missing something and DM's blkdev refcount mgmt couldn't
> trigger this WARN_ON()? I fail to see how to avoid it given the device
> isn't thre so write_inode_now() fails.
>
> > What's wrong with that? Should it be just a kernel log of level KERN_WARN
> > instead?
>
> Ideally, but I honestly don't have all the details paged in my head to
> say definitively. First need to answer how vitrio-blk isn't hitting
> this (and DM is). Could it be that __blkdev_put isn't getting called
> for virtio-blk!?

Just a warnings if fine. In fact we can probably remove that as well
as it will happen after a hot removal all the time.


\
 
 \ /
  Last update: 2015-06-19 09:01    [W:0.091 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site