Messages in this thread Patch in this message | | | Date | Thu, 18 Jun 2015 05:08:35 -0700 | From | tip-bot for Russell King <> | Subject | [tip:irq/core] irq: irq-keystone: Fix race in installing chained IRQ handler |
| |
Commit-ID: 9414b6e2d55d0f7f07c3336d972818af366ae120 Gitweb: http://git.kernel.org/tip/9414b6e2d55d0f7f07c3336d972818af366ae120 Author: Russell King <rmk+kernel@arm.linux.org.uk> AuthorDate: Tue, 16 Jun 2015 23:06:56 +0100 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Thu, 18 Jun 2015 14:03:08 +0200
irq: irq-keystone: Fix race in installing chained IRQ handler
Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data().
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Cc: Alexandre Courbot <gnurou@gmail.com> Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Lee Jones <lee.jones@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/E1Z4z0S-0002Ss-1V@rmk-PC.arm.linux.org.uk Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- drivers/irqchip/irq-keystone.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-keystone.c b/drivers/irqchip/irq-keystone.c index 5dc6165..81e3cf5 100644 --- a/drivers/irqchip/irq-keystone.c +++ b/drivers/irqchip/irq-keystone.c @@ -184,8 +184,7 @@ static int keystone_irq_probe(struct platform_device *pdev) platform_set_drvdata(pdev, kirq); - irq_set_chained_handler(kirq->irq, keystone_irq_handler); - irq_set_handler_data(kirq->irq, kirq); + irq_set_chained_handler_and_data(kirq->irq, keystone_irq_handler, kirq); /* clear all source bits */ keystone_irq_writel(kirq, ~0x0);
| |