lkml.org 
[lkml]   [2015]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] clk: st: make use of of_clk_parent_fill helper function
Hi

Tested-by Gabriel Fernandez <gabriel.fernandez@st.com>

Best Regards.

On 06/10/2015 11:49 PM, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Use of_clk_parent_fill to fill in the parent clock names' array.
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Peter Griffin <peter.griffin@linaro.org>
> Cc: Gabriel FERNANDEZ <gabriel.fernandez@st.com>
> ---
> drivers/clk/st/clk-flexgen.c | 6 ++----
> drivers/clk/st/clkgen-mux.c | 7 ++-----
> 2 files changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c
> index 657ca14..ed0696c 100644
> --- a/drivers/clk/st/clk-flexgen.c
> +++ b/drivers/clk/st/clk-flexgen.c
> @@ -243,7 +243,7 @@ static const char ** __init flexgen_get_parents(struct device_node *np,
> int *num_parents)
> {
> const char **parents;
> - int nparents, i;
> + int nparents;
>
> nparents = of_clk_get_parent_count(np);
> if (WARN_ON(nparents <= 0))
> @@ -253,10 +253,8 @@ static const char ** __init flexgen_get_parents(struct device_node *np,
> if (!parents)
> return NULL;
>
> - for (i = 0; i < nparents; i++)
> - parents[i] = of_clk_get_parent_name(np, i);
> + *num_parents = of_clk_parent_fill(np, parents, nparents);
>
> - *num_parents = nparents;
> return parents;
> }
>
> diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c
> index 4fbe6e0..b83654a 100644
> --- a/drivers/clk/st/clkgen-mux.c
> +++ b/drivers/clk/st/clkgen-mux.c
> @@ -24,7 +24,7 @@ static const char ** __init clkgen_mux_get_parents(struct device_node *np,
> int *num_parents)
> {
> const char **parents;
> - int nparents, i;
> + int nparents;
>
> nparents = of_clk_get_parent_count(np);
> if (WARN_ON(nparents <= 0))
> @@ -34,10 +34,7 @@ static const char ** __init clkgen_mux_get_parents(struct device_node *np,
> if (!parents)
> return ERR_PTR(-ENOMEM);
>
> - for (i = 0; i < nparents; i++)
> - parents[i] = of_clk_get_parent_name(np, i);
> -
> - *num_parents = nparents;
> + *num_parents = of_clk_parent_fill(np, parents, nparents);
> return parents;
> }
>



\
 
 \ /
  Last update: 2015-06-11 10:01    [W:0.091 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site