lkml.org 
[lkml]   [2015]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] clk: sunxi: make use of of_clk_parent_fill helper function
Hi Dinh,

On Wed, Jun 10, 2015 at 04:49:24PM -0500, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Use of_clk_parent_fill to fill in the parent clock names' array.
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: "Emilio López" <emilio@elopez.com.ar>
> ---
> drivers/clk/sunxi/clk-a20-gmac.c | 3 +--
> drivers/clk/sunxi/clk-factors.c | 4 +---
> drivers/clk/sunxi/clk-sun6i-ar100.c | 3 +--
> drivers/clk/sunxi/clk-sunxi.c | 10 ++--------
> 4 files changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/clk/sunxi/clk-a20-gmac.c b/drivers/clk/sunxi/clk-a20-gmac.c
> index 0dcf4f2..a432edd 100644
> --- a/drivers/clk/sunxi/clk-a20-gmac.c
> +++ b/drivers/clk/sunxi/clk-a20-gmac.c
> @@ -80,8 +80,7 @@ static void __init sun7i_a20_gmac_clk_setup(struct device_node *node)
> goto free_mux;
>
> /* gmac clock requires exactly 2 parents */
> - parents[0] = of_clk_get_parent_name(node, 0);
> - parents[1] = of_clk_get_parent_name(node, 1);
> + of_clk_parent_fill(node, parents, 2);
> if (!parents[0] || !parents[1])

Maybe this check can be changed to something like:

if (of_clk_parent_fill(node, parents, 2) != 2)
goto free_gate;

Would that make sense?

Thanks,
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-06-11 11:21    [W:0.111 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site